| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Magnus Hagander <mha(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Make float4byval and float8byval configurable on MSVC. |
| Date: | 2008-04-21 17:26:33 |
| Message-ID: | 20080421192633.27d5b3cc@mha-laptop |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > Magnus Hagander wrote:
> >> Make float4byval and float8byval configurable on MSVC.
>
> > Should we now remove the entries for these 2 defines in
> > pg_config.h.win32 ?
>
> It looked to me like the patch-as-applied relied on their being there.
> I thought it was a bit ugly though. +1 for reverting my change to
> pg_config.h.win32 and making the script insert the correct #defines in
> all four cases.
It does rely on it, because I thought it was needed by the mingw port.
And yes, I realise that makes no sense at all, now that I think about
it :-) Will fix.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2008-04-21 18:37:28 | pgsql: Clean up float4byval and float8byval handling by dealing with |
| Previous Message | Tom Lane | 2008-04-21 17:19:55 | Re: pgsql: Make float4byval and float8byval configurable on MSVC. |