Re: src/include/utils/float.h comment one link stable

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: src/include/utils/float.h comment one link stable
Date: 2025-10-08 13:58:12
Message-ID: 2655460.1759931892@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
>> I'd be happy for someone else to
>> continue. I'm a bit hesitant due to the "#if defined(NAN) &&
>> !(defined(__NetBSD__) && defined(__mips__))", which are systems I have
>> little knowledge of.

> Fair enough, I'll take responsibility for that bit. Might as well
> wait to see how the BF likes the INFINITY change, though.

The three active Windows animals all seem happy with INFINITY,
ditto Solaris and derivatives. So I'll proceed with changing
the NAN support similarly.

As a side note: I realized while researching the commit history
that there are copies of get_float8_infinity and get_float8_nan
in src/interfaces/ecpg/ecpglib/data.c. Will take care of those
while at it, and maybe put in a cross-reference to help the
next hacker.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2025-10-08 14:01:33 Re: VACUUM (PARALLEL) option processing not using DefElem the way it was intended
Previous Message Robert Haas 2025-10-08 13:31:47 Re: RFC: extensible planner state