| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SHA-2 functions |
| Date: | 2018-02-20 22:09:48 |
| Message-ID: | 26129.1519164588@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 2/19/18 21:07, Michael Paquier wrote:
>> varlena.c is already large and messy. I would suggest to split into a
>> new file all the user-facing cryptographic functions, including md5 and
>> hex functions, say in src/backend/utils/adt/crypt.c.
> I had originally started a new file called hash.c, but I figured that
> would be quite confusing. I can use crypt.c or a similar name.
> Although crypt.c sounds a lot like crypt().
cryptohashes.c or some such? I concur with Michael that dropping this
into varlena.c isn't a great plan.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-02-20 22:43:18 | TupleTableSlot abstraction |
| Previous Message | Peter Eisentraut | 2018-02-20 22:05:37 | Re: SHA-2 functions |