|From:||Michael Paquier <michael(at)paquier(dot)xyz>|
|To:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|Cc:||Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: SHA-2 functions|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Tue, Feb 20, 2018 at 05:09:48PM -0500, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> On 2/19/18 21:07, Michael Paquier wrote:
>>> varlena.c is already large and messy. I would suggest to split into a
>>> new file all the user-facing cryptographic functions, including md5 and
>>> hex functions, say in src/backend/utils/adt/crypt.c.
>> I had originally started a new file called hash.c, but I figured that
>> would be quite confusing. I can use crypt.c or a similar name.
>> Although crypt.c sounds a lot like crypt().
> cryptohashes.c or some such? I concur with Michael that dropping this
> into varlena.c isn't a great plan.
I think that crypto_hash.c or hash_crypt.c would be adapted as well.
crypt.c is too much generic, so including both concepts in the name is
the way to go. The name given by Tom here sounds actually nice.
|Next Message||Masahiko Sawada||2018-02-21 04:30:38||Re: Duplicate Item Pointers in Gin index|
|Previous Message||Peter Geoghegan||2018-02-21 03:31:12||Re: Duplicate Item Pointers in Gin index|