| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Put back ERANGE test in dpow(). |
| Date: | 2007-01-06 04:07:37 |
| Message-ID: | 26099.1168056457@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-patches |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Actually, when you return ERANGE, what is 'result'? Nan? Inf? finite?
I believe it's HUGE_VAL (the largest finite value) ... which is
something I don't want to explicitly test for, any more than I liked
the explicit use of min/max values before. Your isinf test is OK
because the point is that we want to replace any non-Inf result with Inf
if the result overflowed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2007-01-06 04:14:55 | pgsql: Improve dpow() check for ERANGE overflow for HPPA. |
| Previous Message | Bruce Momjian | 2007-01-06 04:01:51 | Re: [COMMITTERS] pgsql: Put back ERANGE test in |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gurjeet Singh | 2007-01-06 04:48:45 | Re: A patch to pg_regress for Windows port |
| Previous Message | Joshua D. Drake | 2007-01-06 04:05:56 | Re: [HACKERS] wal_checksum = on (default) | off |