Re: [COMMITTERS] pgsql: Put back ERANGE test in

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Put back ERANGE test in
Date: 2007-01-06 04:01:51
Message-ID: 200701060401.l0641po02755@momjian.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > It ERANGE's only on Inf, not underflow? I would prefer:
> > else if (errno == ERANGE && !isinf(result))
>
> No objection to that, just don't take out the ERANGE test altogether
> again ;-)

Actually, when you return ERANGE, what is 'result'? Nan? Inf? finite?

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-01-06 04:07:37 Re: [COMMITTERS] pgsql: Put back ERANGE test in dpow().
Previous Message Tom Lane 2007-01-06 03:52:17 Re: [COMMITTERS] pgsql: Put back ERANGE test in dpow().

Browse pgsql-patches by date

  From Date Subject
Next Message Joshua D. Drake 2007-01-06 04:05:56 Re: [HACKERS] wal_checksum = on (default) | off
Previous Message Tom Lane 2007-01-06 03:57:32 Re: [HACKERS] wal_checksum = on (default) | off