From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Greg Smith <greg(at)2ndquadrant(dot)com>, Amit kapila <amit(dot)kapila(at)huawei(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Subject: | Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review]) |
Date: | 2013-07-25 20:58:55 |
Message-ID: | 25950.1374785935@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Robert Haas escribi:
>> On Mon, Jul 22, 2013 at 7:56 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I'd be inclined to think that ALTER SYSTEM SET should not be allowed to
>>> modify any PGC_POSTMASTER parameters.
>> That significantly decreases the usefulness of ALTER SYSTEM without
>> actually preventing the underlying problem. If having multiple
>> conflicting values for parameters in the config files doesn't work
>> cleanly, then we should fix that, not cripple this feature.
> I think the only solution that makes sense here is to comment out the
> entry in postgresql.conf.
Actually, this is much ado about nothing. If you actually put two
conflicting values for shared_buffers into postgresql.conf, you'll
find out that:
1. on initial start, the server just silently adopts the later one.
2. if you SIGHUP, you get:
LOG: autovacuum launcher started
LOG: received SIGHUP, reloading configuration files
LOG: parameter "shared_buffers" cannot be changed without restarting the server
LOG: configuration file "/home/postgres/version93/data/postgresql.conf" contains errors; unaffected changes were applied
We could possibly improve the code to not produce that log bleat, but
it's hardly a show-stopper as is.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2013-07-25 21:02:16 | Re: install libpq.dll in bin directory on Windows / Cygwin |
Previous Message | Andrew Dunstan | 2013-07-25 20:53:45 | install libpq.dll in bin directory on Windows / Cygwin |