Re: install libpq.dll in bin directory on Windows / Cygwin

Andrew Dunstan wrote:
> Jeff Janes asked me about this, and Bruce just tripped up on it.
> Usually on Windows it's necessary to have libpq.dll/cygpq.dll either
> in the PATH or in the same directory as client .exe files. The
> buildfarm client has for many years simply copied this dll from the
> installation lib to the installation bin directory after running
> "make install". But I can't really see why we don't do that as part
> of "make install" anyway. I haven't tested but I think something
> like this patch would achieve this goal - it would fix something
> that's tripped a lot of people up over the years.

Seems a reasonable workaround for a silly platform bug. Do you need to
patch the MSVC stuff as well?

> Comments? If we do this, should it be backported?

To 9.3, sure, but not further back, as there's probably little point.

> +ifneq (,$findstring($(PORTNAME), win32 cygwin))
> + $(INSTALL_DATA) $(shlib) '$(DESTDIR)$(bindir)/$(shlib)'
> +endif

I wonder if someday we will create a win64 $(PORTNAME) value, or
something like that, and then we'll have to update the port list on
which these hacks are applied all over the place. Not complaining
about this patch in particular, just an idle thought.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services