Re: Autovaccuum vs temp tables crash

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Autovaccuum vs temp tables crash
Date: 2019-02-22 14:45:42
Message-ID: 25504.1550846742@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> The reason for the crash is 6d842be6c11, where Tom added an assert for
> passing null into %s. But I don't think we can blame that patch for the
> problem -- it's passing the NULL there in the first place that's the
> problem.

Indeed; this crash existed on some platforms all along (which means
we'd better back-patch the fix).

> AFAICT the actual drop works fine, it's just the logging that crashes. So
> maybe we should just add a check and make it log something like "<dropped>"
> if pg_namespace_name() returns null?

+1 ... maybe "(dropped)", because we tend to use parens for this sort
of thing, I think.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2019-02-22 14:50:17 Re: psql show URL with help
Previous Message Derek Hans 2019-02-22 14:44:05 Update does not move row across foreign partitions in v11