Re: Thoughts on using Text::Template for our autogenerated code?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Thoughts on using Text::Template for our autogenerated code?
Date: 2023-03-30 18:04:54
Message-ID: 254739.1680199494@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Corey Huinker <corey(dot)huinker(at)gmail(dot)com> writes:
> Is there a barrier to us using non-core perl modules, in this case
> Text::Template?

Use for what exactly?

I'd be hesitant to require such things to build from a tarball,
or to run regression tests. If it's used to build a generated file
that we include in tarballs, that might be workable ... but I'd bet
a good fraction of the buildfarm falls over (looks like all four of
my animals would), and you might get push-back from developers too.

> I think it would be a tremendous improvement in readability and
> maintainability over our current series of print statements, some
> multiline, some not.

I suspect it'd have to be quite a remarkable improvement to justify
adding a new required build tool ... but show us an example.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2023-03-30 18:13:51 Re: postgres_fdw, dblink, and CREATE SUBSCRIPTION security
Previous Message Andrey Lepikhov 2023-03-30 17:20:19 Re: [POC] Allow an extension to add data into Query and PlannedStmt nodes