"Claimed" status on Commitfest pages

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Brendan Jurd" <direvus(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: "Claimed" status on Commitfest pages
Date: 2008-05-10 04:49:22
Message-ID: 25352.1210394962@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I see that Brendan has proposed the following definition on
CommitFest:Help:

Reviewing items

If you are reviewing an item, let the other developers know by setting
the claimed parameter of the patch to your name. For example, if you
started reviewing the following patch
{{patch|abcd(at)mail(dot)domain|Add bell and/or whistle|Some Guy}}
you would change it to
{{patch|abcd(at)mail(dot)domain|Add bell and/or whistle|Some Guy|claimed=Some Reviewer}}

I'm not too pleased with this because it suggests that "reviewing" is
something only one person can do at a time. What I'd like to see is
guidelines more along these lines:

* Short one-or-two-lines comments can be put right into a {{comment}}
item on the commitfest page.

* If you have a more substantive review, post it on the mailing lists
as a reply to the original patch. Optionally post a link to it as
a {{comment}} on the commitfest page.

* If you are a committer and are taking up the patch for final review
with intent to commit, then mark the commitfest item as "claimed" so
that other committers will not step on your toes.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2008-05-10 05:14:35 Re: Setting a pre-existing index as a primary key
Previous Message Tom Lane 2008-05-10 03:49:58 Re: psql wrapped format default for backslash-d commands