From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
Subject: | Re: Automatic testing of patches in commit fest |
Date: | 2017-09-12 15:30:33 |
Message-ID: | 25089.1505230233@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Tom Lane wrote:
>> Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> writes:
>>> === Apply Failed: 29 ===
>>> https://commitfest.postgresql.org/14/1235/ (Support arrays over domain types)
>> Can you clarify what went wrong for you on that one? I went to rebase it,
>> but I end up with the identical patch except for a few line-numbering
>> variations.
> I think "git apply" refuses to apply a patch if it doesn't apply
> exactly. So you could use "git apply -3" (which merges) or just plain
> old "patch" and the patch would work fine.
> If the criteria is that strict, I think we should relax it a bit to
> avoid punting patches for pointless reasons. IOW I think we should at
> least try "git apply -3".
FWIW, I always initially apply patches with good ol' patch(1). So for
me, whether that way works would be the most interesting thing. Don't
know about other committers' workflows.
> Also, at this point this should surely be just an experiment.
+1 ... seems like there's enough noise here that changing patch status
based on the results might be premature. Still, I applaud the effort.
One thing I'm a tad worried about is automatically running trojan-horsed
submissions. I hope the CI bot is tightly sandboxed.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bossart, Nathan | 2017-09-12 15:31:37 | Re: [Proposal] Allow users to specify multiple tables in VACUUM commands |
Previous Message | Masahiko Sawada | 2017-09-12 15:29:56 | Re: DROP SUBSCRIPTION hangs if sub is disabled in the same transaction |