| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: Automatic testing of patches in commit fest |
| Date: | 2017-09-12 14:34:26 |
| Message-ID: | 20170912143426.krngpqoclqvhthdx@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> writes:
> > I've ended up with this script [1]. It just generates a list of patches
> > that are in "Needs Review" status but don't apply or don't compile. Here
> > is the current list:
>
> > === Apply Failed: 29 ===
> > https://commitfest.postgresql.org/14/1235/ (Support arrays over domain types)
>
> Can you clarify what went wrong for you on that one? I went to rebase it,
> but I end up with the identical patch except for a few line-numbering
> variations.
I think "git apply" refuses to apply a patch if it doesn't apply
exactly. So you could use "git apply -3" (which merges) or just plain
old "patch" and the patch would work fine.
If the criteria is that strict, I think we should relax it a bit to
avoid punting patches for pointless reasons. IOW I think we should at
least try "git apply -3".
Also, at this point this should surely be just an experiment.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-09-12 14:36:55 | Re: Patch: Add --no-comments to skip COMMENTs with pg_dump |
| Previous Message | Simon Riggs | 2017-09-12 14:33:34 | Re: [PROPOSAL] Temporal query processing with range types |