| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Non-portable shell code in pg_upgrade tap tests |
| Date: | 2018-07-22 18:53:51 |
| Message-ID: | 24717.1532285631@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Noah Misch <noah(at)leadboat(dot)com> writes:
> On Sun, Jul 22, 2018 at 10:46:03AM -0400, Tom Lane wrote:
>> The pg_upgrade makefile does in fact use $(SHELL), so it will default to
>> whatever shell configure used.
> It will not, because we don't set $(SHELL) anywhere. $(SHELL) is not @SHELL(at)(dot)
> In our makefiles, $(SHELL) is always /bin/sh, the GNU make default.
Oh! Hm, I wonder whether we shouldn't do that, ie add SHELL = @SHELL@
to Makefile.global.in.
A quick trawl of the buildfarm logs says most of our animals compute
SHELL = /bin/sh anyway, and so would be unaffected. There's a sizable
population that find /bin/bash though, and one active critter that finds
/bin/ksh.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2018-07-22 18:57:01 | Re: JIT breaks PostGIS |
| Previous Message | Andres Freund | 2018-07-22 18:51:06 | Re: JIT breaks PostGIS |