| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Non-portable shell code in pg_upgrade tap tests |
| Date: | 2018-07-23 07:00:54 |
| Message-ID: | 20180723070054.GF3998719@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jul 22, 2018 at 02:53:51PM -0400, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
> > On Sun, Jul 22, 2018 at 10:46:03AM -0400, Tom Lane wrote:
> >> The pg_upgrade makefile does in fact use $(SHELL), so it will default to
> >> whatever shell configure used.
>
> > It will not, because we don't set $(SHELL) anywhere. $(SHELL) is not @SHELL(at)(dot)
> > In our makefiles, $(SHELL) is always /bin/sh, the GNU make default.
>
> Oh! Hm, I wonder whether we shouldn't do that, ie add SHELL = @SHELL@
> to Makefile.global.in.
I see that as the right way forward.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 임명규 | 2018-07-23 07:04:42 | [Proposal] Add accumulated statistics for wait event |
| Previous Message | Michael Paquier | 2018-07-23 06:59:16 | Re: Fix calculations on WAL recycling. |