| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Maksim Milyutin <milyutinma(at)gmail(dot)com> |
| Subject: | Re: [HACKERS] Proposal: Local indexes for partitioned table |
| Date: | 2017-12-21 09:58:06 |
| Message-ID: | 242e9c8d-113e-22e5-05bf-550eb0801f7b@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Alvaro,
On 12/20/2017 04:25 PM, Alvaro Herrera wrote:
> I modified the regression test so that a partitioning hierarchy would be
> left behind after the test is run, which is useful to test pg_upgrade
> and pg_dump -- this caught one small bug. That and some reading of the
> diff resulted in v8, attach.
>
> On my system, make check-world passes. However, Thomas Munro's
> automated patch tester seems to have a problem with the pg_upgrade test,
> though I don't know what it is.
>
Passes check-world here too w/ TAP + cassert.
index.c:
+ values[Anum_pg_index_indparentidx - 1 ] =
ObjectIdGetDatum(parentIndexOid);
Extra space.
tab-complete.c:
Contains references to DETACH.
create_index.sgml:
I think the new paragraph should mention the naming convention of the
generated indexes, as they may differ from the index name on the
partition table.
reindex.sgml:
Missing a note about REINDEX not being supported on the partition index.
Best regards,
Jesper
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2017-12-21 10:22:36 | Re: The pg_indent on on ftp is outdated |
| Previous Message | Andres Freund | 2017-12-21 09:55:50 | Re: pgsql: Add parallel-aware hash joins. |