| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Oops in fe-auth.c |
| Date: | 2007-07-23 14:28:57 |
| Message-ID: | 24126.1185200937@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> When run in debug mode, the runtime for msvc will *zero-pad the entire
> buffer* in a strncpy() call. This in itself is not bad (just slow), but it
> shows a rather bad bug in libpq.
[squint] That is the specified behavior of strncpy on every platform,
not only msvc. If there's a bug here why didn't we notice it long ago?
> Given this, I'll go ahead and fix fe-connect to support PQExpBuffers,
> unless there are any objections.
I'm not against that, but I question what bug you've really found.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-07-23 14:34:18 | Re: SSPI vs MingW |
| Previous Message | Magnus Hagander | 2007-07-23 14:12:13 | Re: [HACKERS] Oops in fe-auth.c |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2007-07-23 14:36:00 | Re: Oops in fe-auth.c |
| Previous Message | Magnus Hagander | 2007-07-23 14:12:13 | Re: [HACKERS] Oops in fe-auth.c |