Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgreSQL(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel
Date: 2018-10-11 20:57:02
Message-ID: 23860.1539291422@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> I've done that now, together with two commits for removal of timetravel
> and abstime, reltime, tinterval.

Unsurprisingly-in-retrospect, buildfarm member crake is now bitching
that cross-version pg_upgrade fails, since it's trying to test importing
back-branch regression DBs that contain tables with the desupported types.

Perhaps the best fix for this is to teach the cross-version-upgrade
buildfarm module to drop the affected tables from the old DB before
testing pg_upgrade. However, that does nothing to help manual testing
of similar scenarios.

Another idea would be to put table drops into the back branch regression
tests, so that their ending states don't include any such tables. That
would cripple pg_dump testing of these types in the back branches, but
I'm not sure if we really care much.

I don't especially like either of these choices --- anyone got another
idea?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-10-11 21:00:58 Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel
Previous Message Dmitry Dolgov 2018-10-11 20:49:04 Re: [HACKERS] [PATCH] Generic type subscripting