| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Noah Misch <noah(at)leadboat(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "Augustine, Jobin" <jobin(dot)augustine(at)openscg(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Replication to Postgres 10 on Windows is broken |
| Date: | 2017-08-13 21:35:43 |
| Message-ID: | 23512.1502660143@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> As a measure of last restart we could add a libpq workaround that forces
> a pqSocketCheck() at the right moment, while still establishing a
> connection. That's not good from an interruptability perspective, but
> better than blocking for the entire connection establishment.
Probably a better idea is to fix things so that can't-send-yet results
in returning PGRES_POLLING_WRITING rather than a failure. That would
result in a busy-wait in this scenario on Windows, which is arguably
better than blocking. It would also make this part of libpq more robust
against applications being sloppy about socket readiness checks (which,
you could argue, is exactly what libpqwalreceiver is being). But it
would be a somewhat ticklish change because of the portability hazards,
so I'm really disinclined to do it this late in beta.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2017-08-13 22:36:09 | Re: [BUGS] Replication to Postgres 10 on Windows is broken |
| Previous Message | Andres Freund | 2017-08-13 21:22:22 | Re: [HACKERS] Replication to Postgres 10 on Windows is broken |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-08-13 21:43:10 | Re: Patches I'm thinking of pushing shortly |
| Previous Message | Tom Lane | 2017-08-13 21:24:59 | Re: Patches I'm thinking of pushing shortly |