| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Failure with 004_logrotate in prairiedog |
| Date: | 2021-07-19 14:23:46 |
| Message-ID: | 234876.1626704626@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Jul 19, 2021 at 04:15:36PM +0900, Kyotaro Horiguchi wrote:
>> When rotation happens, the metainfo file is once removed then
>> created. If slurp_file in the metafile-checking loop hits the gap, the
>> slurp_file fails with ENOENT.
> I can read the following code, as of update_metainfo_datafile():
> if (rename(LOG_METAINFO_DATAFILE_TMP, LOG_METAINFO_DATAFILE) != 0)
Yeah, ignore my previous message. There is an unlink up at the top
of the function, which fooled me in my caffeine-deprived state.
But that path is only taken when logging was just turned off, so
we must remove the now-irrelevant metafile.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2021-07-19 14:31:37 | Re: postgresql.conf.sample missing units |
| Previous Message | Tom Lane | 2021-07-19 14:19:02 | Re: Failure with 004_logrotate in prairiedog |