Re: Failure with 004_logrotate in prairiedog

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: michael(at)paquier(dot)xyz, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Failure with 004_logrotate in prairiedog
Date: 2021-07-19 14:19:02
Message-ID: 234637.1626704342@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> writes:
> When rotation happens, the metainfo file is once removed then
> created. If slurp_file in the metafile-checking loop hits the gap, the
> slurp_file fails with ENOENT.

Oh! Yeah, that's dumb, we should fix it to use rename(). Can't blame
platform's rename() if it's not being used.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-07-19 14:23:46 Re: Failure with 004_logrotate in prairiedog
Previous Message Tom Lane 2021-07-19 14:13:27 Re: O_DIRECT on macOS