Re: Support custom socket directory in pg_upgrade

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support custom socket directory in pg_upgrade
Date: 2018-10-09 14:22:08
Message-ID: 23326.1539094928@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> Having hit the maximum socketdir length error a number of times in pg_upgrade,
> especially when running tests in a deep directory hierarchy, I figured it was
> time to see if anyone else has had the same problem? The attached patch is
> what I run with locally to avoid the issue, it adds a --socketdir=PATH option
> to pg_upgrade which overrides the default use of CWD. Is that something that
> could be considered?

I think you could simplify matters if you installed the CWD default value
during option processing.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Konstantin Knizhnik 2018-10-09 14:26:49 Re: out-of-order XID insertion in KnownAssignedXids
Previous Message Tom Lane 2018-10-09 14:19:12 Re: Add overflow test in function numeric_exp.