Re: pgsql: Disk-based Hash Aggregation.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Davis <jdavis(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Disk-based Hash Aggregation.
Date: 2020-03-23 06:05:06
Message-ID: 23196.1584943506@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Jeff Davis <jdavis(at)postgresql(dot)org> writes:
> Disk-based Hash Aggregation.

I noticed that the regression tests seemed suddenly slower than they
have been. A bit of poking around reveals that this patch made
groupingsets.sql take approximately 8X longer than it used to,
and more than twice as long as any other core regression test.

This is absolutely, positively, not acceptable for a test that gets
run hundreds of times a day by lots of people and buildfarm animals.

If there's no way to test the feature in some significantly-cheaper way,
perhaps we should move this test out to a separate script that's not run
by default.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-03-23 15:58:22 pgsql: Fix our getopt_long's behavior for a command line argument of ju
Previous Message Michael Paquier 2020-03-23 04:40:13 pgsql: Revert "Refactor compile-time assertion checks in c.h"

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2020-03-23 06:30:25 Re: [HACKERS] [PATCH] Generic type subscripting
Previous Message Amit Kapila 2020-03-23 05:04:37 Re: doc review for parallel vacuum