|From:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|To:||Simon Riggs <simon(at)2ndquadrant(dot)com>|
|Cc:||Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org|
|Subject:||Re: For what should pg_stop_backup wait?|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
>> So thinking we should test XLogArchiveCheckDone() for both
>> stopxlogfilename and history file and then stat for the stop WAL file:
> This seems better.
Somehow I missed the 5-Apr patch that introduced this bogosity.
Next time you make a fundamental change in the behavior of a function,
how about updating its comment to match?
After studying it for a minute, I think that XLogArchiveCheckDone no
longer even has a clearly explainable purpose; it needs to be split
into two functions with two different behaviors. I plan to revert
XLogArchiveCheckDone to its previous behavior and introduce
XLogArchiveIsBusy (flipping the sense of the result) to use in
regards, tom lane
|Next Message||hubert depesz lubaczewski||2008-09-08 16:03:39||Re: Fast REVERSE() function?|
|Previous Message||Mario Weilguni||2008-09-08 15:49:53||Re: Fast REVERSE() function?|