| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Maxim Orlov <orlovmg(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use "?=" operator for a contrib makefile in documentation |
| Date: | 2025-09-29 12:50:17 |
| Message-ID: | 22cabb0d-dd5c-4c32-b426-0938c475b886@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 25.09.25 15:17, Maxim Orlov wrote:
> I think that the Makefile should be written so that variable values,
> specifically, PG_CONFIG, can be given to it from the environment rather
> than the make command line. As a result, using the "?=" operator rather
> than "=" to set a default value to the PG_CONFIG variable appears more
> acceptable.
I think the current text is preferable. This allows running
make PG_CONFIG=...
so that you can pick a different PostgreSQL installation for a
particular build.
If you always want to use a particular PostgreSQL installation, then you
could alter the PATH in the environment.
I don't know that there is a use case of setting only PG_CONFIG in the
environment that is not covered by these other two approaches.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matheus Alcantara | 2025-09-29 13:23:03 | Remove unused parameter form find_window_run_conditions() |
| Previous Message | Florents Tselai | 2025-09-29 12:34:18 | Re: Add jsonb_translate(jsonb, from, to) |