| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, Yuqi Gu <Yuqi(dot)Gu(at)arm(dot)com>, "pgsql-hackers\(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Optimize Arm64 crc32c implementation in Postgresql |
| Date: | 2018-05-03 16:01:04 |
| Message-ID: | 22655.1525363264@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> Tom> I also noticed that we'd been sloppy about making the file safe to
> Tom> compile for both frontend and backend, so I cleaned that up.
> In a frontend, wouldn't it be more kosher to restore the previous SIGILL
> handler rather than unconditionally reset it to SIG_DFL?
If we had any other code that was setting the SIGILL trap, I might
worry about that, but we don't.
The whole thing is really a bit questionable to run in arbitrary
environments -- for instance, it'd be pretty unsafe inside a threaded
application. So if we had code in libpq or ecpg that computed CRCs,
I'd be worrying about this approach quite a bit more. But it seems all
right for current and foreseen uses.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vladimir Sitnikov | 2018-05-03 16:19:48 | Re: GSoC 2018: thrift encoding format |
| Previous Message | Andrew Gierth | 2018-05-03 15:54:40 | Re: Optimize Arm64 crc32c implementation in Postgresql |