Re: Mail thread references in commits

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Joshua Drake <jd(at)commandprompt(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Mail thread references in commits
Date: 2016-11-19 16:38:48
Message-ID: 22639.1479573528@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 11/19/2016 10:11 AM, Stephen Frost wrote:
>> That's actually not the case if we use a hash, because the client could
>> figure out what the hash is before sending it.

> The fact that it could possibly be done is not a good reason for doing
> it.

Quite. I will *not* go along with any proposal that requires me to
duplicate some hashing logic being done elsewhere. Way too much risk
of error there.

> Every proposal along these lines strikes me as making more unobvious
> hoops for people to jump through. We're just reinventing the wheel here
> because we don't like the color of the standard wheels that some email
> MUAs produce.

Yeah, anything like this would be going very very far out of our way to
keep these lines in commit messages under an arbitrary limit (which we're
already exceeding anyway in many cases). I'm inclined to think we should
just straight up decide that having the message link be a clickable URL is
worth the longer lines, or that it is not. Personally I vote for "not",
but I recognize that I might be in the minority.

BTW, before we give up completely on reconciling the two objectives,
is anyone aware of a line-continuation convention that would be likely
to work? If we could do something like

Discussion: https://www.postgresql.org/message-id/\
CAF4Au4w6rrH_j1bvVhzpOsRiHCog7sGJ3LSX0tY8ZdwhHT88LQ(at)mail(dot)gmail(dot)com

it would improve matters all around.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-11-19 17:04:27 Re: Mail thread references in commits
Previous Message Joshua D. Drake 2016-11-19 16:31:33 Re: Mail thread references in commits