Re: Fix logical decoding not track transaction duringSNAPBUILD_BUILDING_SNAPSHOT

From: ocean_li_996 <ocean_li_996(at)163(dot)com>
To: cca5507 <cca5507(at)qq(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix logical decoding not track transaction duringSNAPBUILD_BUILDING_SNAPSHOT
Date: 2025-11-22 16:05:49
Message-ID: 22629b65.34f0.19aac508585.Coremail.ocean_li_996@163.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi ChaoAo,
At 2025-11-22 18:34:23, "cca5507" <cca5507(at)qq(dot)com> wrote:
>One important thing is that we must not skip any call to ReorderBufferXidSetCatalogChanges() (direct or indirect) during fast-forwarding or building snapshot, because the historic snapshot only tracks txns with catalog changes, the v6-0004 seems to skip it in xact_decode().

>
v6-0004 only skip the transaction commited during START state and precedeing next_phase_at
(set when changing to BUILDING_SNAPSHOT state) during BUILDING_SNAPSHOT. Those transactions
are always useless no matter in fast forward or not. Plaese recheck v6-0004 again.

>Here is a related bug: > >https://www.postgresql.org/message-id/flat/tencent_3A071B760AA1A38540B57F297332B7781C08%40qq.com >

Yeah, I have researched that issue. I think your analyze is correct for me. But it is
independent of this thread. Let's discuss it in thread where the issues belongs to.

Best regards,
Haiyang Li

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2025-11-22 17:02:10 Re: 10% drop in code line count in PG 17
Previous Message Robert Haas 2025-11-22 15:25:48 Re: pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent