Re: table/index fillfactor control, try 3

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: table/index fillfactor control, try 3
Date: 2006-07-03 03:21:45
Message-ID: 22446.1151896905@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> Thank you for applying, but sorry, my patch has some incompletions.

I'm busy reviewing/reworking this patch, and will deal with these items.

> 2. Add a comment on the average FSM request size. Now, the size
> contains not only the size of tuples, but also freespace on pages.

Yeah, I noticed this and thought it was probably a pretty bad idea:
it plays hob with the notion of tracking a moving average of freespace
requests. I'm not sure what else to do though. Do we want the FSM to
explicitly account for fillfactor, and if so how exactly? There's
certainly no point in returning a page that doesn't have space for the
fillfactor padding.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-07-03 03:29:19 Re: [HACKERS] PQescapeIdentifier
Previous Message Tom Lane 2006-07-03 03:11:14 Re: note about syntax for fillfactor patch

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-07-03 03:29:19 Re: [HACKERS] PQescapeIdentifier
Previous Message Bruce Momjian 2006-07-03 02:15:23 Re: Client build of MSVC6+ patch