From: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: table/index fillfactor control, try 3 |
Date: | 2006-07-03 01:56:02 |
Message-ID: | 20060703103325.566A.ITAGAKI.TAKAHIRO@oss.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Patch applied. Thanks.
Thank you for applying, but sorry, my patch has some incompletions.
1. A debug code is left. Assert() and if-test are redundant.
2. Add a comment on the average FSM request size. Now, the size
contains not only the size of tuples, but also freespace on pages.
Especially, there may be a room to discuss on 2; it changed the meaning of
'average request size'. If it is enough only to add a comment, please apply
the following fixes.
diff -cpr pgsql-orig/src/backend/access/heap/hio.c pgsql/src/backend/access/heap/hio.c
*** pgsql-orig/src/backend/access/heap/hio.c Mon Jul 3 09:22:49 2006
--- pgsql/src/backend/access/heap/hio.c Mon Jul 3 10:22:40 2006
*************** RelationGetBufferForTuple(Relation relat
*** 108,115 ****
otherBlock;
bool needLock;
- if (relation->rd_options == NULL)
- elog(ERROR, "RelationGetBufferForTuple %s IS NULL", RelationGetRelationName(relation));
Assert(relation->rd_options != NULL);
len = MAXALIGN(len); /* be conservative */
--- 108,113 ----
diff -cpr pgsql-orig/src/backend/storage/freespace/freespace.c pgsql/src/backend/storage/freespace/freespace.c
*** pgsql-orig/src/backend/storage/freespace/freespace.c Mon Jul 3 09:22:50 2006
--- pgsql/src/backend/storage/freespace/freespace.c Mon Jul 3 10:30:26 2006
*************** RecordAndGetPageWithFreeSpace(RelFileNod
*** 341,346 ****
--- 341,348 ----
/*
* GetAvgFSMRequestSize - get average FSM request size for a relation.
*
+ * Retuened value is the average of item size plus freespace specified
+ * by fillfactor.
* If the relation is not known to FSM, return a default value.
*/
Size
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-07-03 03:11:14 | Re: note about syntax for fillfactor patch |
Previous Message | ITAGAKI Takahiro | 2006-07-03 01:03:53 | Re: note about syntax for fillfactor patch |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2006-07-03 02:15:23 | Re: Client build of MSVC6+ patch |
Previous Message | Bruce Momjian | 2006-07-02 19:48:24 | Re: ADD/DROPS INHERIT (actually INHERIT / NO INHERIT) |