Re: Do we still need gen_node_support.pl's nodetag ABI stability check?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Do we still need gen_node_support.pl's nodetag ABI stability check?
Date: 2026-04-16 01:46:46
Message-ID: 2233110.1776304006@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> On 15 Apr 2026, at 21:30, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>> This might still be helpful because it checks during local builds and doesn't rely on the buildfarm.

> But does it actually give a good enough answer to be relied upon when passing
> the local check can fail the buildfarm check?

Yeah, my answer to that is still "why is this particular case more
important than any other ABI breakage you might cause while hacking
on a back branch?". I quite agree that being able to check for ABI
breakage locally can be useful. But what we ought to do is make it
easier for people to use libabigail for that without spinning up a
local buildfarm instance. Perhaps we could extract the buildfarm's
ABICompCheck.pm script into some standalone tool.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-04-16 02:05:08 Re: [PATCH] Fix wrong comment in JsonTablePlanJoinNextRow()
Previous Message Tender Wang 2026-04-16 01:45:05 Re: pg_plan_advice