Re: Do we still need gen_node_support.pl's nodetag ABI stability check?

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Do we still need gen_node_support.pl's nodetag ABI stability check?
Date: 2026-04-15 19:47:05
Message-ID: 1977660F-C5E3-427B-AD2F-56F66803C320@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 15 Apr 2026, at 21:30, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 14.04.26 07:04, Tom Lane wrote:
>> On the one hand, there's much to be said for belt-and-suspenders-too
>> safety checks. On the other hand, updating gen_node_support.pl is
>> an extra manual step while creating a branch, so it's easy to forget
>> or get wrong. It's also not very clear why this particular sort
>> of ABI break in a stable branch is any worse than other hazards.
>
> This might still be helpful because it checks during local builds and doesn't rely on the buildfarm.

But does it actually give a good enough answer to be relied upon when passing
the local check can fail the buildfarm check?

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2026-04-15 20:18:04 Re: First draft of PG 19 release notes
Previous Message Robert Haas 2026-04-15 19:46:58 Re: pg_plan_advice