Re: 4 pgcrypto regressions failures - 1 unsolved

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Marko Kreen <marko(at)l-t(dot)ee>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: 4 pgcrypto regressions failures - 1 unsolved
Date: 2005-07-12 20:29:09
Message-ID: 22268.1121200149@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Marko Kreen <marko(at)l-t(dot)ee> writes:
> Hopefully the last regression failure.

> - openssl.c used EVP_MAX_KEY_LENGTH / EVP_MAX_IV_LENGTH
> constants for buffers, which are small in case of
> OpenSSL 0.9.6x and internal AES. (I tested it with
> 0.9.7 only, so I didn't notice...)
> - Also I noticed that the wrapper macros for CBC mode
> do not update IV buffer.
> - As the previous mistake was not picked up by current
> regression tests, I added a 'longer than a block'
> test to all ciphers.

Applied, thanks.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-07-12 20:36:17 Re: PL/Perl list value return causes segfault
Previous Message Marko Kreen 2005-07-12 19:51:58 Re: 4 pgcrypto regressions failures - 1 unsolved

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-07-12 20:30:17 Re: pgcrypto warnings for Sun's cc
Previous Message David Fetter 2005-07-12 20:01:56 Re: [PATCHES] Doc patch: New PL/Perl Features