Re: 4 pgcrypto regressions failures - 1 unsolved

From: Marko Kreen <marko(at)l-t(dot)ee>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: 4 pgcrypto regressions failures - 1 unsolved
Date: 2005-07-12 09:51:44
Message-ID: 20050712095144.GA25317@l-t.ee
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Hopefully the last regression failure.

- openssl.c used EVP_MAX_KEY_LENGTH / EVP_MAX_IV_LENGTH
constants for buffers, which are small in case of
OpenSSL 0.9.6x and internal AES. (I tested it with
0.9.7 only, so I didn't notice...)
- Also I noticed that the wrapper macros for CBC mode
do not update IV buffer.
- As the previous mistake was not picked up by current
regression tests, I added a 'longer than a block'
test to all ciphers.

--
marko

Attachment Content-Type Size
oldssl.fix.diff text/plain 10.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Fuhr 2005-07-12 13:04:52 PL/Perl list value return causes segfault
Previous Message Koichi Suzuki 2005-07-12 09:11:40 Re: A couple of patches for PostgreSQL 64bit support

Browse pgsql-patches by date

  From Date Subject
Next Message Michael Fuhr 2005-07-12 13:04:52 PL/Perl list value return causes segfault
Previous Message Koichi Suzuki 2005-07-12 09:11:40 Re: A couple of patches for PostgreSQL 64bit support