From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | Peter <pmc(at)citylink(dot)dinoex(dot)sub(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: 12.1 not useable: clientlib fails after a dozen queries (GSSAPI ?) |
Date: | 2020-01-10 20:58:10 |
Message-ID: | 22249.1578689890@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
Stephen Frost <sfrost(at)snowman(dot)net> writes:
> Ah-hah. Not sure if that was Robbie or myself (probably me, really,
> since I rewrote a great deal of that code). I agree that the regression
> tests don't test with very much data, but I tested pushing quite a bit
> of data through and didn't see any issues with my testing. Apparently I
> was getting pretty lucky. :/
You were *very* lucky, because this code is absolutely full of mistakes
related to incomplete reads, inadequate or outright wrong error handling,
etc.
I was nearly done cleaning that up, when it sank into me that
fe-secure-gssapi.c uses static buffers for partially-read or
partially-encoded data. That means that any client trying to use
multiple GSSAPI-encrypted connections is very likely to see breakage
due to different connections trying to use the same buffers concurrently.
I wonder whether that doesn't explain the complaints mentioned upthread
from the Ruby folks.
(be-secure-gssapi.c is coded identically, but there it's OK since
any backend only has one client connection to deal with.)
>> I'll have a patch in a little while.
> That's fantastic, thanks!
This is gonna take longer than I thought.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Peter | 2020-01-10 21:03:37 | Re: 12.1 not useable: clientlib fails after a dozen queries (GSSAPI ?) |
Previous Message | Stephen Frost | 2020-01-10 20:38:07 | Re: 12.1 not useable: clientlib fails after a dozen queries (GSSAPI ?) |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter | 2020-01-10 21:03:37 | Re: 12.1 not useable: clientlib fails after a dozen queries (GSSAPI ?) |
Previous Message | Alvaro Herrera | 2020-01-10 20:56:49 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |