More pgindent tweaks

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: More pgindent tweaks
Date: 2023-01-25 13:59:44
Message-ID: 21bb8573-9e56-812b-84cf-1e4f3c4c2a7b@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

After I committed 1249371632 I thought that I should really go ahead and
do what I suggested and allow multiple exclude pattern files for
pgindent. One obvious case is to exclude an in tree meson build
directory. I also sometimes have other in tree objects I'd like to be
able exclude.

The attached adds this ability. It also unifies the logic for finding
the regular exclude pattern file and the typedefs file.

I took the opportunity to remove a badly thought out and dangerous
feature whereby the first non-option argument, if it's not a .c or .h
file, is taken as the typedefs file. That's particularly dangerous in a
situation where git is producing a list of files that have changed and
passing it on the command line to pgindent. I also removed a number of
extraneous blank lines.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachment Content-Type Size
pgindent-tweaks.diff text/x-patch 4.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message songjinzhou 2023-01-25 14:18:17 Re: Re: Support plpgsql multi-range in conditional control
Previous Message Robert Haas 2023-01-25 13:52:28 Re: old_snapshot_threshold bottleneck on replica