Re: Add OID descriptions to dumped parse/query/plan trees

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add OID descriptions to dumped parse/query/plan trees
Date: 2025-08-25 00:10:44
Message-ID: 21A5DAC2-B62A-4E7A-8619-ABD8D470243D@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Aug 22, 2025, at 22:10, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> writes:
>> When reading dumped parse/query/plan trees, sometime we want to know
>> what exact type/operator/function an OID stands for. I just added a new
>> feature that will add some OID descriptions to the dump trees, like:
>
> The extra catalog accesses that could occur might also
> cause problems, maybe even deadlocks in some uses. I'd prefer to
> keep the flexibility to be able to call pprint from pretty much
> anywhere.
>
> Also, AFAICS this breaks re-reading of dump trees, which breaks all
> kinds of stuff (rules, views, parallel query, etc).
>
> regards, tom lane

Thanks for pointing out that, I withdraw the patch.

--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-08-25 00:54:43 Fixes a trivial bug in dumped parse/query/plan trees
Previous Message Peter Smith 2025-08-25 00:08:09 Re: Add support for specifying tables in pg_createsubscriber.