Re: Add OID descriptions to dumped parse/query/plan trees

Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> writes:
> When reading dumped parse/query/plan trees, sometime we want to know
> what exact type/operator/function an OID stands for. I just added a new
> feature that will add some OID descriptions to the dump trees, like:

This is really quite a bad idea. It means that the dump code has to
execute in a live (not-aborted) transaction, which is not a
requirement it had before, and will complicate some debugging
scenarios. The extra catalog accesses that could occur might also
cause problems, maybe even deadlocks in some uses. I'd prefer to
keep the flexibility to be able to call pprint from pretty much
anywhere.

Also, AFAICS this breaks re-reading of dump trees, which breaks all
kinds of stuff (rules, views, parallel query, etc).

regards, tom lane