Re: [HACKERS] Should libedit be preferred to libreadline?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org, "Jim C(dot) Nasby" <jnasby(at)pervasive(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Seneca Cunningham <scunning(at)ca(dot)afilias(dot)info>
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Date: 2005-12-02 14:14:31
Message-ID: 2198.1133532871@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches pgsql-ports

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> I'm concerned that this still gives nondeterministic behavior. There's
> no way to say, "I want readline, period" or "I want libedit, period".
> I'd prefer simple --with-readline and --with-libedit, giving one turns
> off the other, giving both is an error.

OTOH that doesn't provide a way to express "I'll take either". Given
that I'll-take-either has so far satisfied 99.44% of users, getting rid
of it doesn't seem like the best plan.

It might be possible to set things up so that you can specify "I'll take
either" by writing both switches, and further that the order in which
you write the switches determines the preference --- though I'm not
entirely sure how to do the latter within the autoconf framework.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-12-02 14:18:01 Re: Shared locking in slru.c
Previous Message Pollard, Mike 2005-12-02 12:57:50 Re: generalizing the planner knobs

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2005-12-02 15:02:14 Re: [HACKERS] Should libedit be preferred to libreadline?
Previous Message Andreas Seltenreich 2005-12-02 13:59:30 Re: TODO item -- Improve psql's handling of multi-line queries

Browse pgsql-ports by date

  From Date Subject
Next Message Andrew Dunstan 2005-12-02 15:02:14 Re: [HACKERS] Should libedit be preferred to libreadline?
Previous Message Peter Eisentraut 2005-12-02 08:28:19 Re: [HACKERS] Should libedit be preferred to libreadline?