Re: reconsider_full_join_clause fails to consider if COALESCE() arguments are NULL-preserving

From: Tomas Vondra <tomas(at)vondra(dot)me>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: reconsider_full_join_clause fails to consider if COALESCE() arguments are NULL-preserving
Date: 2026-11-19 14:42:57
Message-ID: 215b59bd-a42e-4ed2-948d-8faef00aebd1@vondra.me
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I've pushed the v4 fix with some minor adjustments.

The fix does not include the JsonExpr/CoerceToDomain fixes, so these
cases are not handled correctly. I consider that to be a separate
preexisting issue, present in contain_nonstrict_functions_walker(), and
there's a separate thread about that. I could have fixed that in the new
walker in "my" way, but I think it's better to agree on a common fix and
apply it to both places. I don't see a reason to not fix this FULL JOIN
issue independently of that.

regards

--
Tomas Vondra

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2026-11-19 14:46:40 Re: [PATCH]Fix planner's strictness check for JsonExpr
Previous Message He Kuang 2026-11-19 14:34:47 [PATCH v3] Estimate hash join bucket size from the joint ndistinct of the hash keys