| From: | Tomas Vondra <tomas(at)vondra(dot)me> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: reconsider_full_join_clause fails to consider if COALESCE() arguments are NULL-preserving |
| Date: | 2026-11-16 13:43:56 |
| Message-ID: | 510012cf-422a-449b-9f08-3e8c75356b15@vondra.me |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/13/26 18:19, Kirill Reshke wrote:
> On Fri, 13 Nov 2026 at 17:11, Tomas Vondra <tomas(at)vondra(dot)me> wrote:
>>
>
>>
>> I'm now fairly happy with the patch. I'm considering whether to push it
>> now before the 19 freeze ...
>
> go
>
No.
I needed a bit more time to be sure it's correct, and I didn't want to
be the person who derails PG19 release by committing an incorrect fix on
Friday 13th.
After looking more I think the fix is correct, but I while reviewing the
new walker I found a separate bug in the existing one, due to not
checking JsonExpr / CoerceToDomain properly. See [1].
That's mostly orthogonal, but the new walker will need to handle the two
nodes in a similar way.
regards
[1] https://postgr.es/m/b368a3ca-b196-4c28-8050-50320e9c955d@vondra.me
--
Tomas Vondra
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2026-11-16 13:44:57 | Re: Document prepared transaction lock waits with two_phase subscriptions |
| Previous Message | Tomas Vondra | 2026-11-16 13:38:40 | contain_nonstrict_functions_walker() fails to consider JsonExpr and CoerceToDomain |