Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)
Date: 2021-06-12 00:56:19
Message-ID: 2137765.1623459379@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> OK, I came up with the attached patch. This is one of the few cases
> where the incompatibility is not clearly related to the feature, so I
> left the existing item alone and just created a new one with the same
> commit message in the incompatibilities section.

I think phrasing this as though user-defined aggregates are the only
pain point is incorrect. For example, a custom operator based on
array_cat would have issues too.

I suggest a treatment more like

Some built-in array-related functions changed signature (Tom Lane)

Certain functions were redefined to take anycompatiblearray instead
of anyarray. While this does not affect ordinary calls, it does
affect code that directly names these functions along with their
argument types; for example, custom aggregates and operators based
on these functions. The affected functions are [ blah, blah ]

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2021-06-12 01:12:55 Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)
Previous Message Justin Pryzby 2021-06-12 00:43:47 Re: cleanup temporary files after crash