| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tim Uckun <timuckun(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUGS] BUG #6034: pg_upgrade fails when it should not. |
| Date: | 2011-06-01 17:21:03 |
| Message-ID: | 21309.1306948863@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>>> I think you misread what I wrote, or I misexplained it, but never
>>> mind. Matching locale names case-insensitively sounds reasonable to
>>> me, unless someone has reason to believe it will blow up.
> On FreeBSD, locale names appear to be case-sensitive:
> $ LC_ALL=en_US.UTF-8 locale charmap
> UTF-8
> $ LC_ALL=en_US.utf-8 locale charmap
> US-ASCII
Hm, surely the latter result indicates that "en_US.utf-8" is not in fact
a valid locale name?
It would only be a problem if different case-foldings of the same name
represented valid but different locales on some platform, and that seems
rather hard to believe (it would be a pretty foolish choice no?).
So I'm inclined to leave the code alone.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-06-01 18:28:37 | Re: BUG #6041: Unlogged table was created bad in slave node |
| Previous Message | Robert Haas | 2011-06-01 17:18:30 | Re: BUG #5903: Turkish encoding problem |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2011-06-01 17:53:12 | Re: creating CHECK constraints as NOT VALID |
| Previous Message | Andrew Dunstan | 2011-06-01 17:19:53 | Re: [HACKERS] DOCS: SGML identifier may not exceed 44 characters |