Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.

On ons, 2011-06-01 at 13:21 -0400, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> >>> I think you misread what I wrote, or I misexplained it, but never
> >>> mind. Matching locale names case-insensitively sounds reasonable to
> >>> me, unless someone has reason to believe it will blow up.
>
> > On FreeBSD, locale names appear to be case-sensitive:
>
> > $ LC_ALL=en_US.UTF-8 locale charmap
> > UTF-8
>
> > $ LC_ALL=en_US.utf-8 locale charmap
> > US-ASCII
>
> Hm, surely the latter result indicates that "en_US.utf-8" is not in fact
> a valid locale name?
>
> It would only be a problem if different case-foldings of the same name
> represented valid but different locales on some platform, and that seems
> rather hard to believe (it would be a pretty foolish choice no?).

Well, initdb still succeeds if you give it an invalid locale name. It
warns, but that can easily be missed if initdb is hidden behind a few
other layers. If you then run pg_upgrade, you get a hosed instance.