Re: Useless "Replica Identity: NOTHING" noise from psql \d

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Useless "Replica Identity: NOTHING" noise from psql \d
Date: 2014-03-23 15:49:37
Message-ID: 21169.1395589777@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Is this the patch you had in mind? I kept the pg_catalog filter. Do we
> want to always show the replica identity line for \d+?

Doesn't seem like a great idea to remove the filter tests for replident
values and then not fix the display code to cope with those values.

I think this display code is well south of minimal acceptability anyhow:
if the column contains anything other than what it expects, it will print
a lie, meaning it's entirely not future-proof. I'd suggest a switch()
that prints "???" in the default: case.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2014-03-23 16:39:23 Re: psql blows up on BOM character sequence
Previous Message Guillaume Lelarge 2014-03-23 15:03:19 Re: psql blows up on BOM character sequence