Re: Useless "Replica Identity: NOTHING" noise from psql \d

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Useless "Replica Identity: NOTHING" noise from psql \d
Date: 2014-03-24 16:03:06
Message-ID: 20140324160306.GB15836@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Mar 23, 2014 at 11:49:37AM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Is this the patch you had in mind? I kept the pg_catalog filter. Do we
> > want to always show the replica identity line for \d+?
>
> Doesn't seem like a great idea to remove the filter tests for replident
> values and then not fix the display code to cope with those values.
>
> I think this display code is well south of minimal acceptability anyhow:
> if the column contains anything other than what it expects, it will print
> a lie, meaning it's entirely not future-proof. I'd suggest a switch()
> that prints "???" in the default: case.

Oh, good points. I have updated the attached patch.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

Attachment Content-Type Size
replica.diff text/x-diff 10.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-03-24 16:06:25 Re: Useless "Replica Identity: NOTHING" noise from psql \d
Previous Message MauMau 2014-03-24 14:19:29 Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation