Re: pg_stat_statements vs. SELECT FOR UPDATE

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_stat_statements vs. SELECT FOR UPDATE
Date: 2019-01-19 17:00:30
Message-ID: 21047.1547917230@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
> I propose that it should not ignore rowMarks, per the attached patch or
> something similar.

+1 for not ignoring rowMarks, but this patch seems like a hack to me.
Why didn't you just add RowMarkClause as one of the known alternative
expression node types? There's no advantage to hard-wiring such
restrictive assumptions about where it can appear.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-01-19 17:02:09 Re: pg_stat_statements vs. SELECT FOR UPDATE
Previous Message Tom Lane 2019-01-19 16:49:52 A small note on the portability of cmake