Re: pgsql: Add a note about another issue that needs to be considered before

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add a note about another issue that needs to be considered before
Date: 2007-11-05 16:10:50
Message-ID: 20806.1194279050@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> FWIW I found another issue with this variable when I was experimenting with
> small block sizes. If you set the target <= the tuple header the toaster
> breaks. This is because it's doing unsigned arithmetic (Size is unsigned). I
> think the right solution is just to change it to use plain int32 arithmetic
> everywhere.

Somehow I can't get excited about that. If we ever do open things up to
allow user control of the target, we'd certainly constrain it to a sane
range.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-11-05 16:11:04 Re: Patch for testing query modes on pgbench
Previous Message Bruce Momjian 2007-11-05 16:10:39 Re: Proposal: PL/pgSQL EXECUTE INTO USING (for 8.4)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-11-05 16:21:05 Re: pgsql: Document txid functions.
Previous Message Bruce Momjian 2007-11-05 16:06:20 Re: pgsql: Document txid functions.