Re: Wrong order of tests in findDependentObjects()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Wrong order of tests in findDependentObjects()
Date: 2016-12-01 23:28:56
Message-ID: 20649.1480634936@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> writes:
> On 12/1/16 1:09 PM, Tom Lane wrote:
>> I think that the patch I wrote is good cleanup, so I'm still inclined
>> to apply it in HEAD, but I no longer think it's fixing any case that's
>> significant in the field. I wonder if you have a counterexample?

> No; I'm sure I've run into this because of a temp object other than a
> table (probably a function, though possibly something else).

Makes sense. The fact that we protect against this for temp tables and
views would make it all the more surprising when you get bit by some
less-common object type.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-12-01 23:36:00 Re: Broken SSL tests in master
Previous Message Andres Freund 2016-12-01 23:16:02 Re: Mail thread references in commits