Andres Freund <andres(at)anarazel(dot)de> writes:
> For the umpteenth time I was annoyed by the names of labels in
> heapam.c. It's really not useful to see a 'goto l1;' etc.
Yeah, those label names are uninformative as can be.
> How about renaming l1 to retry_delete_locked, l2 to retry_update_locked,
> l3 to retry_lock_tuple_locked etc? Especially with the subsidiary
> functions for updates and locking, it's not always clear from context
> where the goto jumps to.
Is it practical to get rid of the goto's altogether? If not,
renaming would be an improvement.
regards, tom lane